This repository was archived by the owner on Jul 14, 2025. It is now read-only.
Removing "and avatar" that is not supported from the doc#97
Closed
jmlord wants to merge 4 commits intodiscourse:mainfrom
Closed
Removing "and avatar" that is not supported from the doc#97jmlord wants to merge 4 commits intodiscourse:mainfrom
jmlord wants to merge 4 commits intodiscourse:mainfrom
Conversation
Member
|
Plugin moving to core |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refers to this issue:
https://meta.discourse.org/t/oauth2-plugin-avatar-not-used/295121
Since I can't find and fix the bug, at least adjusting the documentation makes sense to me. This only affects the initial token documentation, since the avatar works with the a-postiori json query.
I propagated to only to the languages I understand. If it makes sense for the plugin maintainers to propagate it to all languages we should do that, but I wanted to wait until confirmation that the issue will not be otherwise fixed.